Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kafka Destination issue Fixed. sasl_jaas_config #9905

Closed
wants to merge 2 commits into from
Closed

Kafka Destination issue Fixed. sasl_jaas_config #9905

wants to merge 2 commits into from

Conversation

data-storyteller
Copy link

…sasl_jaas_config" and "sasl_mechanism" throwing null pointer exception.

What

While using SASL config to connect for Kafka Producer, It's giving NullPointerExecption as It's not able to read Kafka Consumer config "sasl_jaas_config" and "sasl_mechanism".

How

These Kafka consumer configs should be read from the "protocol" config JsonNode object else not able to find in parent JsonNode "config" object. So replaced config with "protocolConfig".

Recommended reading order

  1. x.java
  2. y.python

🚨 User Impact 🚨

Users will be able to use the Kafka Source connector using SASL configurations.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/SUMMARY.md
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the connector is published, connector added to connector index as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the new connector version is published, connector version bumped in the seed directory as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Connector Generator

  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed.

@data-storyteller
Kafka Source Destination issue Fixed :Not able to read kafka config "…
f76199e 
…sasl_jaas_config" and "sasl_mechanism" throwing null pointer exception.
@CLAassistant
Copy link

CLAassistant commented Jan 31, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Jan 31, 2022
@data-storyteller
Kafka Source Destination issue Fixed :Not able to read kafka config "…
ef50d05 
…sasl_jaas_config" and "sasl_mechanism" throwing null pointer exception.
@data-storyteller data-storyteller changed the title Kafka Source Destination issue Fixed. sasl_jaas_config Kafka Destination issue Fixed. sasl_jaas_config Jan 31, 2022
@data-storyteller
Copy link
Author

/test connector=connectors/destination-kafka

@VitaliiMaltsev
Copy link
Contributor

VitaliiMaltsev commented Feb 1, 2022 •
edited by github-actions bot
Loading

/test connector=connectors/destination-kafka

Error: No ref found for: kafka-dest-fix

@data-storyteller
Copy link
Author

@alafanechere @VitaliiMaltsev After running ./gradlew :airbyte-integrations:connectors:destination-kafka:integrationTest got following results.

Please let me know next steps for this PR.

KafkaDestinationAcceptanceTest > testCustomDbtTransformations() PASSED

Deprecated Gradle features were used in this build, making it incompatible with Gradle 8.0.

You can use '--warning-mode all' to show the individual deprecation warnings and determine if they come from your own scripts or plugins.

See https://docs.gradle.org/7.3.3/userguide/command_line_interface.html#sec:command_line_warnings

Execution optimizations have been disabled for 3 invalid unit(s) of work during this build to ensure correctness.
Please consult deprecation warnings for more details.

BUILD SUCCESSFUL in 3m 41s
77 actionable tasks: 6 executed, 71 up-to-date

@VitaliiMaltsev VitaliiMaltsev mentioned this pull request Feb 2, 2022
Merged
40 tasks
@VitaliiMaltsev
Copy link
Contributor

@alafanechere @VitaliiMaltsev After running ./gradlew :airbyte-integrations:connectors:destination-kafka:integrationTest got following results.

Please let me know next steps for this PR.

KafkaDestinationAcceptanceTest > testCustomDbtTransformations() PASSED

Deprecated Gradle features were used in this build, making it incompatible with Gradle 8.0.

You can use '--warning-mode all' to show the individual deprecation warnings and determine if they come from your own scripts or plugins.

See https://docs.gradle.org/7.3.3/userguide/command_line_interface.html#sec:command_line_warnings

Execution optimizations have been disabled for 3 invalid unit(s) of work during this build to ensure correctness.
Please consult deprecation warnings for more details.

BUILD SUCCESSFUL in 3m 41s
77 actionable tasks: 6 executed, 71 up-to-date

published (your changes)[https://github.com//pull/10005]. This PR can be closed

@alafanechere alafanechere self-assigned this Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VitaliiMaltsev VitaliiMaltsev VitaliiMaltsev approved these changes

Assignees

@alafanechere alafanechere

Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation community connectors/destination/kafka
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@data-storyteller @CLAassistant @VitaliiMaltsev @alafanechere @octavia-squidington-iii